- This topic has 20 replies, 2 voices, and was last updated 7 years, 12 months ago by
Andrew Misplon.
- AuthorPosts
- September 10, 2016 at 5:15 am #4831
AnonymousInactiveHello! After upgrading to the latest version, sticky header seems to have broken for one of my sites. I’m not really sure where I should be looking, to fix this, so would greatly welcome any suggestions.
Thanks!
September 10, 2016 at 11:55 am #4833
Andrew MisplonKeymasterHi Dan
Thanks for posting. I can’t see any problems when checking this morning. Can you perhaps try clearing your caching/optimization plugin and see if anything changes? If nothing changes, can you perhaps, let me know what the details of the problem are? Thanks 🙂
September 10, 2016 at 4:05 pm #4834
AnonymousInactiveAndrew, thanks for the quick reply. I cleared all of my caches. I have sticky header enabled in the theme settings for desktop view, but it appears to be static, and not move at all . I’ve tested on chrome and Firefox both.
Thank you!
September 11, 2016 at 4:07 pm #4838
Andrew MisplonKeymasterThanks for your feedback, I can see now. I think I looked a different site before. Apologies, I might have had too many tabs open.
Phew, so the situation with the new sticky header is that it became really complicated to style if the responsive menu was disabled. Not for the static view but when the header became sticky and the screen size reduced. As a result, we made the sticky header conditional. It requires the responsive menu to be enabled. The idea was to prevent a situation where your header breaks with the menu overflowing the header.
I need to give this some more thought, I can of course see the problem with your setup or anyone else wanting to use MMM or Uber Menu and still keep the sticky header.
Would you like me to make a quick hotfix for you? If so, I’ll need a set of FTP details. Alternatively, if you want to, the hotfix will be made to functions.php line 222.
Currently:
// Sticky header. if ( siteorigin_setting( 'header_sticky' ) && siteorigin_setting( 'navigation_responsive_menu' ) ) { wp_enqueue_script( 'jquery-hc-sticky', get_template_directory_uri() . '/js/jquery.hc-sticky' . SITEORIGIN_THEME_JS_PREFIX . '.js', array( 'jquery' ), '1.2.43', $in_footer ); }
Change to:
// Sticky header. if ( siteorigin_setting( 'header_sticky' ) ) { wp_enqueue_script( 'jquery-hc-sticky', get_template_directory_uri() . '/js/jquery.hc-sticky' . SITEORIGIN_THEME_JS_PREFIX . '.js', array( 'jquery' ), '1.2.43', $in_footer ); }
September 11, 2016 at 4:08 pm #4839
Andrew MisplonKeymasterApologies for the hassle!
September 11, 2016 at 9:17 pm #4840
AnonymousInactiveAndrew,
Thank you again for the quick reply. I applied the hotpatch correctly, but it doesn’t look like it did what we were hoping to. I’m not sure if it’s because I’m currently using a child theme that you whipped up for me a while back, to fix another issue with MMM, or if there’s something else going on.
What would be the next best step? FTP Credentials?
Dan
September 11, 2016 at 9:43 pm #4841
AnonymousInactiveThis reply has been marked as private.September 12, 2016 at 10:43 am #4847
Andrew MisplonKeymasterThanks Dan, taking a look now. I’m trying to remember what we had to fix for MMM. I can see the work, just trying to recall the ‘why’. Chat in a bit.
September 12, 2016 at 10:47 am #4848
Andrew MisplonKeymasterI need to clear cache to see changes take effect. Could you perhaps clear cache and then temporarily deactivate the caching plugin? Thanks.
September 12, 2016 at 12:24 pm #4854
AnonymousInactiveAndrew,
Disabled the caching plugin + autoptimize, and cleared them both. Thanks!
Dan
September 12, 2016 at 12:25 pm #4855
AnonymousInactiveWe made the original changes due to links in the submenu only showing when actively hovering over them, especially in the mega menu.
September 12, 2016 at 2:18 pm #4857
Andrew MisplonKeymasterThanks. Any chance you can set me up with a Administrator account? All is normal with the file structure but for some reason
style.css
(child theme) is blank when viewing the site.September 12, 2016 at 2:42 pm #4864
Andrew MisplonKeymasterThis reply has been marked as private.September 12, 2016 at 3:14 pm #4868
AnonymousInactiveThis reply has been marked as private.September 12, 2016 at 3:19 pm #4870
Andrew MisplonKeymasterAlmost there, if you could bump that account to role Administrator I’ll be able to dive in.
- AuthorPosts
You must be logged in to reply to this topic.