[Resolved] Sticky Header Issue

This topic contains 20 replies, has 2 voices, and was last updated by  Andrew Misplon 1 year, 5 months ago.

  • Author
    Posts
  • #4831

    Dan Dulaney
    Participant

    Hello! After upgrading to the latest version, sticky header seems to have broken for one of my sites. I’m not really sure where I should be looking, to fix this, so would greatly welcome any suggestions.

    Thanks!

    Site: https://www.convexcode.com/

    • This topic was modified 1 year, 5 months ago by  Dan Dulaney.
    #4833

    Andrew Misplon
    Keymaster

    Hi Dan

    Thanks for posting. I can’t see any problems when checking this morning. Can you perhaps try clearing your caching/optimization plugin and see if anything changes? If nothing changes, can you perhaps, let me know what the details of the problem are? Thanks 🙂

    #4834

    Dan Dulaney
    Participant

    Andrew, thanks for the quick reply. I cleared all of my caches. I have sticky header enabled in the theme settings for desktop view, but it appears to be static, and not move at all . I’ve tested on chrome and Firefox both.

    Thank you!

    • This reply was modified 1 year, 5 months ago by  Dan Dulaney.
    #4838

    Andrew Misplon
    Keymaster

    Thanks for your feedback, I can see now. I think I looked a different site before. Apologies, I might have had too many tabs open.

    Phew, so the situation with the new sticky header is that it became really complicated to style if the responsive menu was disabled. Not for the static view but when the header became sticky and the screen size reduced. As a result, we made the sticky header conditional. It requires the responsive menu to be enabled. The idea was to prevent a situation where your header breaks with the menu overflowing the header.

    I need to give this some more thought, I can of course see the problem with your setup or anyone else wanting to use MMM or Uber Menu and still keep the sticky header.

    Would you like me to make a quick hotfix for you? If so, I’ll need a set of FTP details. Alternatively, if you want to, the hotfix will be made to functions.php line 222.

    Currently:

    	// Sticky header.
    	if ( siteorigin_setting( 'header_sticky' ) && siteorigin_setting( 'navigation_responsive_menu' ) ) {
    		wp_enqueue_script( 'jquery-hc-sticky', get_template_directory_uri() . '/js/jquery.hc-sticky' . SITEORIGIN_THEME_JS_PREFIX . '.js', array( 'jquery' ), '1.2.43', $in_footer );			
    	}	

    Change to:

    	// Sticky header.
    	if ( siteorigin_setting( 'header_sticky' ) ) {
    		wp_enqueue_script( 'jquery-hc-sticky', get_template_directory_uri() . '/js/jquery.hc-sticky' . SITEORIGIN_THEME_JS_PREFIX . '.js', array( 'jquery' ), '1.2.43', $in_footer );			
    	}	
    #4839

    Andrew Misplon
    Keymaster

    Apologies for the hassle!

    #4840

    Dan Dulaney
    Participant

    Andrew,

    Thank you again for the quick reply. I applied the hotpatch correctly, but it doesn’t look like it did what we were hoping to. I’m not sure if it’s because I’m currently using a child theme that you whipped up for me a while back, to fix another issue with MMM, or if there’s something else going on.

    What would be the next best step? FTP Credentials?

    Dan

    #4841

    Dan Dulaney
    Participant
    This reply has been marked as private.
    #4847

    Andrew Misplon
    Keymaster

    Thanks Dan, taking a look now. I’m trying to remember what we had to fix for MMM. I can see the work, just trying to recall the ‘why’. Chat in a bit.

    #4848

    Andrew Misplon
    Keymaster

    I need to clear cache to see changes take effect. Could you perhaps clear cache and then temporarily deactivate the caching plugin? Thanks.

    #4854

    Dan Dulaney
    Participant

    Andrew,

    Disabled the caching plugin + autoptimize, and cleared them both. Thanks!

    Dan

    #4855

    Dan Dulaney
    Participant

    We made the original changes due to links in the submenu only showing when actively hovering over them, especially in the mega menu.

    #4857

    Andrew Misplon
    Keymaster

    Thanks. Any chance you can set me up with a Administrator account? All is normal with the file structure but for some reason style.css (child theme) is blank when viewing the site.

    #4864

    Andrew Misplon
    Keymaster
    This reply has been marked as private.
    #4868

    Dan Dulaney
    Participant
    This reply has been marked as private.
    #4870

    Andrew Misplon
    Keymaster

    Almost there, if you could bump that account to role Administrator I’ll be able to dive in.

Viewing 15 posts - 1 through 15 (of 21 total)

You must be logged in to reply to this topic.

Scroll to top