Resolved

Theme Check Results

Polestar Theme started by rolo Oct 3, 2018 2 replies
rolo Oct 3, 2018 · 3:16 pm #10663

Can you fix this errors to have 100% rating?

http://themecheck.org/score/wordpress-theme-polestar.html

1. theme tags : Presence of bad theme tags
Found wrong tag custom-logo in style.css header.

2. Custom elements : Presence of custom header
No reference to custom header was found in the theme.

3. Editor style : Presence of editor style
No reference to add_editor_style() was found in the theme. It is recommended that the theme implements editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Thanks!

Andrew Misplon Puro Oct 3, 2018 · 3:22 pm #10664

Hi rolo 🙂

Good to hear from you.

Sure, I’ll take a look at the tag issue, that needs to be addressed. The tag list might have been updated since I last checked.

The other two items though, custom header and editor styles, those are completely optional. Unfortunately I don’t have any plans to add those to theme at the moment.

I’ll update you once I’ve taken a look at the tag list this evening 🙂

Andrew Misplon Puro Oct 3, 2018 · 4:27 pm #10665

I’m not quite sure why a warning is being thrown for the tag custom-logo. Here is the theme tag list: https://make.wordpress.org/themes/handbook/review/required/theme-tags/.

custom-logo Support custom logos, use add_theme_support( 'custom-logo' );

And here is that support added to Polestar: https://github.com/purothemes/polestar/blob/develop/functions.php#L58

And finally, here is the tag list: https://github.com/purothemes/polestar/blob/develop/style.css#L11. custom-logo is formatted as specified in the WordPress.org theme review tag list.

3 posts