[Resolved] Custom Colour / Current Menu Item

This topic contains 4 replies, has 2 voices, and was last updated by  Andrew Misplon 2 years, 1 month ago.

  • Author
    Posts
  • #5365

    ben_demotic
    Participant

    Hi Andrew

    I think this is a regression, I hope not related to the smooth scrolling to anchor point.

    When navigating to a page via the main menu the CSS class “current-menu-item” is added which sets either the default blue or a custom colour in premium to the menu item of the current page.

    However, when you navigate to an anchor point on the home page from the main menu, despite what colour you have set in the customiser, the current menu item is coloured the default blue. I have checked the HTML and it seems that the CSS class “current” is added instead of “current-menu-item”. I have reverted to the previous version (2.1.4.1) and it seems the correct class is added in this version.

    Could you please advise?

    Thanks

    Ben

    #5366

    Andrew Misplon
    Keymaster

    Hey Ben, thanks for your help. I’ll release a hot fix premium version to resolve. The new current class is missing from the Customizer, that’s the issue. Everything you’re seeing is correct. The previous version was stripping the current-menu-item class after scroll. The new version has split the classes and basically detects when we’re in a one page anchor situation and only then removes the current-menu-item class. Dealing with full urls as not only hash anchor links and the various other usage cases has proved quite tricky. I haven’t seen an example deal with all of the cases we are working with here, they usually fall short in area or the other. Thanks again for your feedback.

    #5371

    Andrew Misplon
    Keymaster

    Thanks again Ben. Hotfix version is out. All should be sorted now. Appreciate your help with this. Let me know how it goes.

    #5376

    ben_demotic
    Participant

    I’ve installed the latest version and the anchor class “current” is now behaving the same as “current-menu-item” showing the correct custom colour.

    As always, thanks for the rapid response and top class support.

    #5377

    Andrew Misplon
    Keymaster

    Super, thanks for your testing, feedback and understanding. Chat soon 🙂 Cheers.

Viewing 5 posts - 1 through 5 (of 5 total)

You must be logged in to reply to this topic.

Scroll to top